made comparison generic with a backwards compatible default

langchain-ai · Dec 21, 2024 · 83a9db6 · 83a9db6
1 parent 6ff9229
commit 83a9db6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/langchain-core/src/structured_query/functional.ts b/langchain-core/src/structured_query/functional.ts
@@ -191,7 +191,7 @@ export class FunctionalTranslator extends BaseTranslator {
    * @param comparison The comparison part of a structured query.
    * @returns A function that takes a `Document` as an argument and returns a boolean based on the comparison.
    */
-  visitComparison(comparison: Comparison): this["VisitComparisonOutput"] {
+  visitComparison(comparison: Comparison<string | number | boolean>): this["VisitComparisonOutput"] {
     const { comparator, attribute, value } = comparison;
     const undefinedTrue = [Comparators.ne];
     if (this.allowedComparators.includes(comparator)) {

diff --git a/langchain-core/src/structured_query/ir.ts b/langchain-core/src/structured_query/ir.ts
@@ -149,13 +149,13 @@ export abstract class FilterDirective extends Expression {}
  * Class representing a comparison filter directive. It extends the
  * FilterDirective class.
  */
-export class Comparison extends FilterDirective {
+export class Comparison<ValueTypes = string | number> extends FilterDirective {
   exprName = "Comparison" as const;
 
   constructor(
     public comparator: Comparator,
     public attribute: string,
-    public value: string | number | boolean
+    public value: ValueTypes
   ) {
     super();
   }