langchain[patch]: fix: Include separator length when checking chunk size #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking splits for chunk size, only 1 separator was considered, this could lead to chunks exceeding the maximum size.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
Dschoordsch
commented
Mar 21, 2024
langchain/src/text_splitter.ts
Outdated
| @@ -188,8 +188,7 @@ export abstract class TextSplitter | |||
| for (const d of splits) { | |||
| const _len = await this.lengthFunction(d); | |||
| if ( | |||
| total + _len + (currentDoc.length > 0 ? separator.length : 0) > | |||
| this.chunkSize | |||
| total + _len + (currentDoc.length * separator.length) > this.chunkSize | |||
There was a problem hiding this comment.
The python version solves this slightly differently by adding and substracting the separator.length to total which adds a bit more clutter
- https://github.com/langchain-ai/langchain/blob/5d220975fc563a92f41aeb0907e8c3819da073f5/libs/text-splitters/langchain_text_splitters/base.py#L133
- https://github.com/langchain-ai/langchain/blob/5d220975fc563a92f41aeb0907e8c3819da073f5/libs/text-splitters/langchain_text_splitters/base.py#L138
- https://github.com/langchain-ai/langchain/blob/5d220975fc563a92f41aeb0907e8c3819da073f5/libs/text-splitters/langchain_text_splitters/base.py#L142
There was a problem hiding this comment.
Shouldn't this be additive rather than multiplicative though?
There was a problem hiding this comment.
Let me think through it a bit more! It's been a while since I've looked at this code.
There was a problem hiding this comment.
Oh, never mind, the naming is bad. I understand now, makes sense!
3 tasks
jacoblee93
changed the title
|
Thank you for this, and sorry for the delayed review! |
…fix/separatorLengthInTextSplitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking splits for chunk size, only 1 separator was considered, this could lead to chunks exceeding the maximum size.