Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Adds placeholder message BaseMessage type #4920

Merged
merged 4 commits into from
Mar 30, 2024
Merged

core[patch]: Adds placeholder message BaseMessage type #4920

merged 4 commits into from
Mar 30, 2024

Conversation

rahilvora
Copy link
Contributor

@rahilvora rahilvora commented Mar 28, 2024 •
edited
Loading

Fixes #4915

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 9:20am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 30, 2024 9:20am

@rahilvora rahilvora force-pushed the rahilvora/add_agent_scratchpad branch from 0f65ae8 to 22ee5ea Compare March 28, 2024 23:36
@rahilvora rahilvora marked this pull request as ready for review March 28, 2024 23:37
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Mar 28, 2024
@rahilvora rahilvora force-pushed the rahilvora/add_agent_scratchpad branch from 22ee5ea to 8f320d9 Compare March 29, 2024 00:37
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Mar 30, 2024 •
edited
Loading

Hey @rahilvora, it's actually a bit simpler than this. We already have a MessagesPlaceholder prompt - we only need this shorthand for declaring prompt templates.

For new core features like this, it also really helps to add tests.

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Mar 30, 2024 •
edited
Loading

See fixes - thank you for the PR!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Mar 30, 2024
@jacoblee93 jacoblee93 changed the title Adds placeholder message BaseMessage type core[patch]: Adds placeholder message BaseMessage type Mar 30, 2024
@jacoblee93 jacoblee93 merged commit 14632b7 into langchain-ai:main Mar 30, 2024
23 checks passed
@rahilvora rahilvora deleted the rahilvora/add_agent_scratchpad branch April 12, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Langsmith Hub Javascript Inline doesn't work
2 participants
@rahilvora @jacoblee93