-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all[minor]: Unified model params #5020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
auto:documentation
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
auto:improvement
Medium size change to existing code to handle new use-cases
labels
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:documentation
Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
auto:improvement
Medium size change to existing code to handle new use-cases
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed:
Based on this notion page
High level
modelName
->model
openAIApiKey
/azureOpenAIApiKey
/(along with a few other smaller providers) ->apiKey
Code changes
In order to keep backwards compatibility, all modules still have
modelName
/the API key as a class property, since they're all public properties and removing would be breaking.For example, if a class used
modelName
, it now would have an additional argumentmodel
and themodelName
JSDoc is updated to sayAlias for "model"
. Inside the constructor, we now prioritizefields?.model > fields?.modelName > this.model
(if there is a default)The above is then set to the
modelName
class property, andmodelName
is then assigned tomodel
. The same logic applies toapiKey
updates.Here is an example of what it looks like in practice:
Class args:
Class constructor:
This way, users can still pass in & access
modelName
, however inside the classthis.modelName
is never used, and instead onlythis.model
is.Search keywords: docs updates: cookbook[patch] core_docs[patch] examples[patch] alises/code updates: langchain[minor] anthropic[minor] azure-openai[minor] cloudflare[minor] community[minor] google-common[minor] google-genai[minor] groq[minor] mistralai[minor] nomic[minor] openai[minor]