Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-common[patch]: adding client-info #5103

Merged
merged 11 commits into from
May 1, 2024
Merged

google-common[patch]: adding client-info #5103

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eddce89
adding client-info
tanyaasharma Apr 15, 2024
742f55b
changes based on comments
tanyaasharma Apr 16, 2024
5d4e5d9
Merge branch 'main' into tanya/client-info
tanyaasharma Apr 17, 2024
1101d43
adding version
tanyaasharma Apr 17, 2024
5dfe107
adding test cases
tanyaasharma Apr 18, 2024
efe4389
setting library version as zero
tanyaasharma Apr 22, 2024
c3f1d16
test updates
tanyaasharma Apr 22, 2024
d2e3ac0
Update connection.ts
jacoblee93 Apr 22, 2024
1329717
Update connection.ts
jacoblee93 Apr 22, 2024
aba3b12
formatting
tanyaasharma Apr 23, 2024
7204d9e
Merge branch 'main' into tanya/client-info
bracesproul May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/langchain-google-common/src/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ export abstract class GoogleConnection<
clientLibraryVersion: string;
}> {
const env = await getRuntimeEnvironment();
const packageJson = require('../package.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've discussed this with @jacoblee93 before (who can correct me if I mis-state something).
Unfortunately, while this works in Node, it doesn't work in all environments. Otherwise it would have been done in getRuntimeEnvironment() (which would be the best place to fix it, so it is available to all packages).

require itself is node-specific, but it isn't the only problem here.

const langchain = env?.library ?? "langchain-js";
const langchainVersion = env?.libraryVersion ?? "0";
const langchainVersion = packageJson.dependencies["@langchain/core"] ?? "0";
const moduleName = await this._moduleName();
let clientLibraryVersion = `${langchain}/${langchainVersion}`;
if (moduleName && moduleName.length) {
Expand Down