-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[patch]: support alibaba_tongyi stream output #5271
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -493,6 +496,109 @@ export class ChatAlibabaTongyi | |||
return this.caller.call(makeCompletionRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that the new code introduces a net-new HTTP request using the fetch
method. I've flagged this for your review to ensure it aligns with the project's architecture and requirements. Let me know if you have any questions or need further clarification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, could you add a test too? Thanks for doing this!
fix type error, add a test |
Thank you! This will be released in about a week along with 0.2 - let me know if you need it cherry picked sooner. |
Fixes # (issue)