feat[langsmith]: transparent handoff between @traceable HOF and LangChain #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
dqbd
force-pushed
the
dqbd/langsmith-traceable-handoff
branch
from
b651f41 to
a648854
Compare
hinthornw
approved these changes
May 17, 2024
dqbd
added a commit
to langchain-ai/langsmith-sdk
that referenced
this pull request
May 17, 2024
- Traceable to LangChain: add the entire tree of RunTrees into the BaseTracer `runMap`, assign the `_parentRunId` to the callback manager - LangChain to Traceable: the `RunnableTraceable` invokes the function without calling `*WithConfig`, avoiding unwanted callback invocation **Verifying package manager behaviour** Exposed the LangChain utilities + added `@langchain/core` as an optional dependency to allow supporting older versions of LangChain. - [x] Yarn 1.x: does not install the `@langchain/core`, not included in package-lock.json - [X] PNPM: does not install `@langchain/core`, included in package-lock.json - [X] NPM: does not install `@langchain/core`, included in package-lock.json - [X] Bun: does not install `@langchain/core`, included in package-lock.json - [X] Deno: does not install `@langchain/core` Upstream PR which implements similar functionality can be seen in langchain-ai/langchainjs#5339 Closes #598
dqbd
force-pushed
the
dqbd/langsmith-traceable-handoff
branch
from
b5d4410 to
0abfa3c
Compare
dosubot
bot
added
size:L
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -57,6 +60,40 @@ export class LangChainTracer | |||
| getEnvironmentVariable("LANGCHAIN_SESSION"); | |||
There was a problem hiding this comment.
Hey there! I noticed that the recent code changes in tracer_langchain.ts explicitly access an environment variable using the getEnvironmentVariable function. I've flagged this for your review to ensure it aligns with our environment variable usage guidelines. Keep up the great work!
dqbd
force-pushed
the
dqbd/langsmith-traceable-handoff
branch
from
d81ea39 to
b849f2d
Compare
jacoblee93
reviewed
May 30, 2024
jacoblee93
reviewed
May 30, 2024
agola11
reviewed
May 30, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@traceableand LangChain