-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cohere[minor]: Fix token counts, add usage_metadata #5732
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d9df403
cohere[minor]: Fix token counts, add usage_metadata
bracesproul 0290115
chore: lint files
bracesproul fc30a10
remove skipped token usage tests from cohere standard int test
bracesproul b38a802
bump min core version to usage_metadata update
bracesproul 448511e
add streamUsage
bracesproul e28c29d
added cohere to latest/lowest dep tests
bracesproul ddf98b1
conditionally run latest/lowest
bracesproul f0cc874
Merge branch 'main' into brace/cohere-token-count
bracesproul 8a4eaa6
nit
bracesproul 0127915
cr
bracesproul 745aa15
cr
bracesproul 87756a9
cr
bracesproul f01e778
revert
bracesproul 427b0a2
test
bracesproul 8676b88
try just pr
bracesproul 7ccce30
cr
bracesproul fe01ba5
cr
bracesproul b586528
only log files
bracesproul 8f22a96
more tests
bracesproul e9d4817
toJson
bracesproul bb17fe5
use git to access changed files
bracesproul c80eb11
Merge branch 'main' into brace/cohere-token-count
bracesproul 5331f45
fix if statements
bracesproul 2a8632e
fix test
bracesproul d57893d
Merge branch 'main' into brace/cohere-token-count
bracesproul 3060a41
unfocus jest tests and add eslint rule
bracesproul 018aa93
add eslint-plugin-jest
bracesproul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
dependency_range_tests/scripts/with_standard_tests/cohere/node/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "dependency-range-tests", | ||
"version": "0.0.0", | ||
"private": true, | ||
"description": "Tests dependency ranges for LangChain.", | ||
"dependencies": { | ||
"semver": "^7.5.4" | ||
} | ||
} |
22 changes: 22 additions & 0 deletions
22
dependency_range_tests/scripts/with_standard_tests/cohere/node/update_resolutions_lowest.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
const fs = require("fs"); | ||
const semver = require("semver"); | ||
|
||
const communityPackageJsonPath = "/app/monorepo/libs/langchain-cohere/package.json"; | ||
|
||
const currentPackageJson = JSON.parse(fs.readFileSync(communityPackageJsonPath)); | ||
|
||
if (currentPackageJson.dependencies["@langchain/core"] && !currentPackageJson.dependencies["@langchain/core"].includes("rc")) { | ||
const minVersion = semver.minVersion( | ||
currentPackageJson.dependencies["@langchain/core"] | ||
).version; | ||
currentPackageJson.overrides = { | ||
...currentPackageJson.overrides, | ||
"@langchain/core": minVersion, | ||
}; | ||
currentPackageJson.dependencies = { | ||
...currentPackageJson.dependencies, | ||
"@langchain/core": minVersion, | ||
}; | ||
} | ||
|
||
fs.writeFileSync(communityPackageJsonPath, JSON.stringify(currentPackageJson, null, 2)); |
22 changes: 22 additions & 0 deletions
22
dependency_range_tests/scripts/with_standard_tests/cohere/node/yarn.lock
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | ||
# yarn lockfile v1 | ||
|
||
|
||
lru-cache@^6.0.0: | ||
version "6.0.0" | ||
resolved "https://registry.yarnpkg.com/lru-cache/-/lru-cache-6.0.0.tgz#6d6fe6570ebd96aaf90fcad1dafa3b2566db3a94" | ||
integrity sha512-Jo6dJ04CmSjuznwJSS3pUeWmd/H0ffTlkXXgwZi+eq1UCmqQwCh+eLsYOYCwY991i2Fah4h1BEMCx4qThGbsiA== | ||
dependencies: | ||
yallist "^4.0.0" | ||
|
||
semver@^7.5.4: | ||
version "7.5.4" | ||
resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.4.tgz#483986ec4ed38e1c6c48c34894a9182dbff68a6e" | ||
integrity sha512-1bCSESV6Pv+i21Hvpxp3Dx+pSD8lIPt8uVjRrxAUt/nbswYc+tK6Y2btiULjd4+fnq15PX+nqQDC7Oft7WkwcA== | ||
dependencies: | ||
lru-cache "^6.0.0" | ||
|
||
yallist@^4.0.0: | ||
version "4.0.0" | ||
resolved "https://registry.yarnpkg.com/yallist/-/yallist-4.0.0.tgz#9bb92790d9c0effec63be73519e11a35019a3a72" | ||
integrity sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A== |
22 changes: 22 additions & 0 deletions
22
dependency_range_tests/scripts/with_standard_tests/cohere/test-with-latest-deps.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euxo pipefail | ||
|
||
export CI=true | ||
|
||
# New monorepo directory paths | ||
monorepo_dir="/app/monorepo" | ||
monorepo_openai_dir="/app/monorepo/libs/langchain-cohere" | ||
|
||
# Run the shared script to copy all necessary folders/files | ||
bash /scripts/with_standard_tests/shared.sh cohere | ||
|
||
# Navigate back to monorepo root and install dependencies | ||
cd "$monorepo_dir" | ||
yarn | ||
|
||
# Navigate into `@langchain/cohere` to build and run tests | ||
# We need to run inside the cohere directory so turbo repo does | ||
# not try to build the package/its workspace dependencies. | ||
cd "$monorepo_openai_dir" | ||
yarn test |
35 changes: 35 additions & 0 deletions
35
dependency_range_tests/scripts/with_standard_tests/cohere/test-with-lowest-deps.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euxo pipefail | ||
|
||
export CI=true | ||
|
||
monorepo_dir="/app/monorepo" | ||
monorepo_cohere_dir="/app/monorepo/libs/langchain-cohere" | ||
updater_script_dir="/app/updater_script" | ||
updater_script_dir="/app/updater_script" | ||
original_updater_script_dir="/scripts/with_standard_tests/cohere/node" | ||
|
||
# Run the shared script to copy all necessary folders/files | ||
bash /scripts/with_standard_tests/shared.sh cohere | ||
|
||
# Copy the updater script to the monorepo | ||
mkdir -p "$updater_script_dir" | ||
cp "$original_updater_script_dir"/* "$updater_script_dir/" | ||
|
||
# Install deps (e.g semver) for the updater script | ||
cd "$updater_script_dir" | ||
yarn | ||
# Run the updater script | ||
node "update_resolutions_lowest.js" | ||
|
||
|
||
# Navigate back to monorepo root and install dependencies | ||
cd "$monorepo_dir" | ||
yarn | ||
|
||
# Navigate into `@langchain/cohere` to build and run tests | ||
# We need to run inside the cohere directory so turbo repo does | ||
# not try to build the package/its workspace dependencies. | ||
cd "$monorepo_cohere_dir" | ||
yarn test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,8 +35,8 @@ | |
"author": "LangChain", | ||
"license": "MIT", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey there! 👋 I noticed that the package.json file has an update for the "cohere-ai" dependency, which seems to be a peer dependency change. I've flagged this for your review. Keep up the great work! 🚀 |
||
"dependencies": { | ||
"@langchain/core": ">0.1.58 <0.3.0", | ||
"cohere-ai": "^7.9.3" | ||
"@langchain/core": ">=0.2.5 <0.3.0", | ||
"cohere-ai": "^7.10.5" | ||
}, | ||
"devDependencies": { | ||
"@jest/globals": "^29.5.0", | ||
|
@@ -53,6 +53,7 @@ | |
"eslint-config-airbnb-base": "^15.0.0", | ||
"eslint-config-prettier": "^8.6.0", | ||
"eslint-plugin-import": "^2.27.5", | ||
"eslint-plugin-jest": "^27.6.0", | ||
"eslint-plugin-no-instanceof": "^1.0.1", | ||
"eslint-plugin-prettier": "^4.2.1", | ||
"jest": "^29.5.0", | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that this PR updates the dependencies for LangChain JS, specifically the peer dependencies "@langchain/core" and "cohere-ai". This is flagged for maintainers to review the changes in peer dependencies. Keep up the great work! 🚀