Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[minor]: Add Indexing API support for Milvus #5760

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

miloradvojnovic
Copy link
Contributor

Summary:

  • Added Indexing API support for Milvus
  • Implemented document addition by id (addDocuments method with ids argument)
  • Implemented delete by id (delete method with ids argument)
  • Bumped Milvus SDK version because Indexing API needs the upsert method
  • Added tests for Milvus Indexing

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 14, 2024
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 8:22am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 14, 2024 8:22am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Jun 14, 2024
@@ -70,7 +70,7 @@
"@upstash/vector": "^1.1.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed that the package.json update includes a change in the version of "@zilliz/milvus2-sdk-node" from "^2.2.7" to "^2.3.5", which affects the hard dependency. I'm flagging this for your review. Keep up the great work! 🚀

@@ -130,7 +130,7 @@
"@writerai/writer-sdk": "^0.40.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the package.json file for LangChain Community has a change in the dependency for "@zilliz/milvus2-sdk-node" from ">=2.2.11" to ">=2.3.5". This comment is to flag the dependency change for maintainers to review. Keep up the great work!

@@ -92,7 +92,10 @@ Harmonic Labyrinth of the dreaded Majotaur?`,
];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've noticed that the recent change in milvus.int.test.ts adds and accesses environment variables via the clientConfig object. I've flagged this for maintainers to review and ensure that the handling of environment variables aligns with best practices. Keep up the great work!

@jacoblee93 jacoblee93 changed the title Add Indexing API support for Milvus community[minor]: Add Indexing API support for Milvus Jun 18, 2024
@jacoblee93
Copy link
Collaborator

Looks great, thank you!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Jun 18, 2024
@jacoblee93 jacoblee93 merged commit 7bcdaf8 into langchain-ai:main Jun 18, 2024
32 of 33 checks passed
@zrg-team
Copy link
Contributor

@miloradvojnovic
i got this issue related to this update.
#5813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants