-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[minor]: Add Indexing API support for Milvus #5760
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -70,7 +70,7 @@ | |||
"@upstash/vector": "^1.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that the package.json update includes a change in the version of "@zilliz/milvus2-sdk-node" from "^2.2.7" to "^2.3.5", which affects the hard dependency. I'm flagging this for your review. Keep up the great work! 🚀
@@ -130,7 +130,7 @@ | |||
"@writerai/writer-sdk": "^0.40.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that the package.json file for LangChain Community has a change in the dependency for "@zilliz/milvus2-sdk-node" from ">=2.2.11" to ">=2.3.5". This comment is to flag the dependency change for maintainers to review. Keep up the great work!
@@ -92,7 +92,10 @@ Harmonic Labyrinth of the dreaded Majotaur?`, | |||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I've noticed that the recent change in milvus.int.test.ts
adds and accesses environment variables via the clientConfig
object. I've flagged this for maintainers to review and ensure that the handling of environment variables aligns with best practices. Keep up the great work!
Looks great, thank you! |
@miloradvojnovic |
Summary: