-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[minor]: Update ChatWebLLM to match dependency version and update example #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Jun 16, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for this - let's also lock to that specific minor version (remove the carat). There have been a few breaking changes in patch releases now CC @CharlieFRuan |
5 tasks
I think will also fix #5771 |
Worked for me! Thank you |
Neet-Nestor
changed the title
community[minor]: Update ChatWebLLM to match new version and update example
community[minor]: Update ChatWebLLM to match dependency version and update example
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mlc-ai/web-llm#477
The current code sample in the documentation is incorrect as it misses the required
initailize()
call and thus the example code won't work. This PR fixes the example code.Meanwhile, this PR also updates WebLLM package from
v0.2.40
tov0.2.46
, locked the version, and updated the function signature ofengine.reload()
to match by removing theappConfig
parameter.