Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[minor]: Update ChatWebLLM to match dependency version and update example #5776

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

Neet-Nestor
Copy link
Contributor

@Neet-Nestor Neet-Nestor commented Jun 16, 2024

Fixes mlc-ai/web-llm#477

The current code sample in the documentation is incorrect as it misses the required initailize() call and thus the example code won't work. This PR fixes the example code.

Meanwhile, this PR also updates WebLLM package from v0.2.40 to v0.2.46, locked the version, and updated the function signature of engine.reload() to match by removing the appConfig parameter.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 16, 2024
Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ❌ Failed (Inspect) Jun 18, 2024 9:39am
langchainjs-docs ❌ Failed (Inspect) Jun 18, 2024 9:39am

@jacoblee93
Copy link
Collaborator

Thanks for this - let's also lock to that specific minor version (remove the carat). There have been a few breaking changes in patch releases now CC @CharlieFRuan

@jacoblee93
Copy link
Collaborator

I think will also fix #5771

@jacoblee93
Copy link
Collaborator

Worked for me! Thank you

@Neet-Nestor Neet-Nestor changed the title community[minor]: Update ChatWebLLM to match new version and update example community[minor]: Update ChatWebLLM to match dependency version and update example Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please ensure you have called MLCEngine.reload(model) to load the model before initiating chat operations
2 participants