aws[major]: Add bedrock embeddings to aws package #6139
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| /* eslint-disable @typescript-eslint/no-non-null-assertion */ | |||
There was a problem hiding this comment.
Hey team, just a heads up that I've flagged a change in the PR that explicitly accesses an environment variable via process.env. It's important for maintainers to review this to ensure proper handling of environment variables.
| @@ -65,6 +65,7 @@ | |||
| "eslint-plugin-prettier": "^4.2.1", | |||
There was a problem hiding this comment.
Hey there! I noticed the addition of the "langchain" dependency with the "workspace:*" value in the package.json. This change is flagged for maintainers to review as it pertains to the management of the dependency within the workspace. Great work, and looking forward to the review!
| @@ -0,0 +1,84 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey team, I've flagged this PR for your review as it includes changes that access environment variables for AWS credentials using process.env. Please take a look to ensure the handling of environment variables aligns with best practices.
Ported from community
Added
langchainas workspace dev dep so I can accessMemoryVectorStorein tests