Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs[minor]: Add multimodal section in Google VertexAI docs #6177

Merged
merged 9 commits into from
Jul 23, 2024
Merged

docs[minor]: Add multimodal section in Google VertexAI docs #6177

merged 9 commits into from
Jul 23, 2024

Conversation

tanyaasharma
Copy link
Contributor

Fixes # (issue)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 7:53pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 23, 2024 7:53pm

@dosubot dosubot bot added the auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Jul 23, 2024
bracesproul
bracesproul requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments, please re-request my review once implemented!

docs/core_docs/docs/integrations/chat/google_vertex_ai.mdx Outdated Show resolved Hide resolved
docs/core_docs/docs/integrations/chat/google_vertex_ai.mdx Outdated Show resolved Hide resolved
examples/src/models/chat/integration_googlevertexai-multimodal.ts Outdated Show resolved Hide resolved
examples/src/models/chat/integration_googlevertexai-tools.ts Outdated Show resolved Hide resolved
@bracesproul bracesproul changed the title updating documentation and code for multimodality docs[minor]: Add multimodal section in Google VertexAI docs Jul 23, 2024
@bracesproul bracesproul marked this pull request as draft July 23, 2024 17:06
bracesproul
bracesproul approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up a couple commits that resolve my requests. Thank you for pushing up this PR! Will get it merged as soon as CI passes.

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 23, 2024
@bracesproul bracesproul marked this pull request as ready for review July 23, 2024 19:37
@bracesproul bracesproul merged commit aa49f8f into langchain-ai:main Jul 23, 2024
20 checks passed
@prathik2401 prathik2401 mentioned this pull request Aug 15, 2024
Merged
@riderx riderx mentioned this pull request Aug 18, 2024
Closed
@sam2177142 sam2177142 mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanyaasharma @bracesproul