fix(qdrant): Support custom payload also when using fromExistingCollection #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:M
jacoblee93
changed the title
jacoblee93
reviewed
Oct 29, 2024
| * @returns Promise that resolves when the documents have been added to the database. | ||
| */ | ||
| async addDocuments( | ||
| documents: Document[], | ||
| documentOptions?: QdrantAddDocumentOptions | ||
| customPayloads?: QdrantCustomPayload[], |
There was a problem hiding this comment.
This is breaking isn't it?
Would prefer to keep the wrapping
There was a problem hiding this comment.
Sure, feel free to keep it 🫣 I understand the urge, but in my opinion I'm always for the correct way instead producing the legacy code of tomorrow. It's yet already complicated enough with the customPayloads on document level and the customPayload on dbConfig level.
But I understand that you don't want to have breaking changes, even a simple one like this.
There was a problem hiding this comment.
Yeah it's a fine line - I'd err towards keeping it for now with a note to change it in the next minor bump.
|
Sounds reasonable :)
Jacob Lee ***@***.***> schrieb am Di., 29. Okt. 2024, 22:04:
… ***@***.**** commented on this pull request.
------------------------------
In libs/langchain-qdrant/src/vectorstores.ts
<#7069 (comment)>
:
> * @returns Promise that resolves when the documents have been added to the database.
*/
async addDocuments(
documents: Document[],
- documentOptions?: QdrantAddDocumentOptions
+ customPayloads?: QdrantCustomPayload[],
Yeah it's a fine line - I'd err towards keeping it for now with a note to
change it in the next minor bump.
—
Reply to this email directly, view it on GitHub
<#7069 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAADHUQ2AZQD4XSVO27MXLZ57Z5JAVCNFSM6AAAAABQUBNZVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBTGA3TQMBRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2756