-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: structured output parser #7144
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Hey @anadi45, thanks for this! Am a bit nervous about swapping this out wholesale since LLMs could perhaps output curly braces in other contexts and I wouldn't want to break anyone depending on the old behavior - what is the issue you are encountering? At minimum this needs a lot more unit tests. |
Hi @jacoblee93, thank you so much for the review! I'm new to open source and wanted to contribute to LangChain since we use it at our organization. I chose this issue as a starting point where the parser currently breaks if there are nested triple backticks. I agree that changing the parsing logic entirely could be risky. To maintain backward compatibility, I could incorporate my logic within a catch block, and only throw an error if both approaches fail. I’ll also explore alternative ways to handle this issue. If you have any other suggestions, I’d be happy to incorporate them! Regardless, I'll add more test cases to cover these scenarios. |
Hey @anadi45, sounds good - please ping again when ready. |
@jacoblee93 should I close this? Looks like #7199 already solved this issue. |
Fixes #(6734)