fix(azure-cosmosdb): Add caches for Azure CosmosDB vCore [comments resolved] #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
jacoblee93
approved these changes
Dec 10, 2024
jacoblee93
changed the title
|
Actually - would love to tag @sinedied for a second look! |
jacoblee93
reviewed
Dec 10, 2024
sinedied
suggested changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks for your contribution!
Could you restructuring the current file structure to:
- src/
- caches/
- nosql.ts
- mongodb.ts
The same could be done for the tests, so you could duplicate the existing test that exist for the NoSQL version to have one for the MongoDB version.
dosubot
bot
added
size:XXL
jacoblee93
reviewed
Dec 16, 2024
libs/langchain-azure-cosmosdb/src/tests/caches/caches_nosql.init.test.ts
Outdated
Show resolved
Hide resolved
jacoblee93
reviewed
Dec 16, 2024
libs/langchain-azure-cosmosdb/src/tests/caches/caches_nosql.init.test.ts
Outdated
Show resolved
Hide resolved
dosubot
bot
added
size:L
|
@jacoblee93 @sinedied comments and conflict resolved, also add test for mongo cache. Could you help review and approve this PR? Thanks a lot |
crisjy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)