-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update tutorials #7358
docs: update tutorials #7358
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This reverts commit 36497ec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this!
"- [Prompt Templates](/docs/concepts/prompt_templates)\n", | ||
"- [Chat History](/docs/concepts/chat_history)\n", | ||
"\n", | ||
"This guide requires `langgraph >= 0.2.28`.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are moving all this to use LangGraph, should we just work towards combine docs?
Not in this PR obviously but in general
"\n", | ||
"This guide (and most of the other guides in the documentation) uses [Jupyter notebooks](https://jupyter.org/) and assumes the reader is as well. Jupyter notebooks are perfect for learning how to work with LLM systems because oftentimes things can go wrong (unexpected output, API down, etc) and going through guides in an interactive environment is a great way to better understand them.\n", | ||
"\n", | ||
"This and other tutorials are perhaps most conveniently run in a Jupyter notebook. See [here](https://jupyter.org/install) for instructions on how to install.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be in a followup but we should have a guide on how to set up TSLab since it's not a typical experience for JS devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
"}\n", | ||
"\n", | ||
"// Here we generate a summary, given a document\n", | ||
"const generateSummary = async (state: SummaryState): Promise<{ summaries: string[] }> => {\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why declare another type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was cargo-culting https://langchain-ai.github.io/langgraphjs/how-tos/map-reduce/
Following langchain-ai/langchain#28219