fix(google-common): Search grounding formatting #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h grounding information.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:S
jacoblee93
reviewed
Jan 9, 2025
| @@ -198,7 +198,7 @@ export class SimpleGoogleSearchOutputParser extends BaseGoogleSearchOutputParser | |||
|
|
|||
| protected textSuffix(_text: string, grounding: GroundingInfo): string { | |||
| let ret = "\n"; | |||
| const chunks: GeminiGroundingChunk[] = grounding.metadata.groundingChunks; | |||
| const chunks: GeminiGroundingChunk[] = grounding?.metadata?.groundingChunks ??[]; | |||
|
Thanks! |
jacoblee93
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If using a subclass of
BaseGoogleSearchOutputParserwhere the input doesn't have grounding info, it attempts to dereference undefined.Solution:
Return the input text, unchanged, if there is no grounding info to annotate.
Fix and tests for same.