Skip to content

langgraph: fix ismethod check in add_node #1402

langgraph: fix ismethod check in add_node

langgraph: fix ismethod check in add_node #1402

Triggered via pull request January 14, 2025 22:08
Status Success
Total duration 44m 21s
Artifacts

bench.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 2 notices
benchmark
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Benchmark results: libs/langgraph/langgraph/graph/state.py#L1
......................................... fanout_to_subgraph_10x: Mean +- std dev: 61.5 ms +- 1.7 ms ......................................... fanout_to_subgraph_10x_sync: Mean +- std dev: 53.1 ms +- 0.7 ms ......................................... fanout_to_subgraph_10x_checkpoint: Mean +- std dev: 74.4 ms +- 0.9 ms ......................................... fanout_to_subgraph_10x_checkpoint_sync: Mean +- std dev: 95.3 ms +- 1.6 ms ......................................... fanout_to_subgraph_100x: Mean +- std dev: 604 ms +- 24 ms ......................................... fanout_to_subgraph_100x_sync: Mean +- std dev: 521 ms +- 15 ms ......................................... fanout_to_subgraph_100x_checkpoint: Mean +- std dev: 751 ms +- 12 ms ......................................... fanout_to_subgraph_100x_checkpoint_sync: Mean +- std dev: 962 ms +- 18 ms ......................................... react_agent_10x: Mean +- std dev: 31.0 ms +- 0.9 ms ......................................... react_agent_10x_sync: Mean +- std dev: 23.0 ms +- 0.3 ms ......................................... react_agent_10x_checkpoint: Mean +- std dev: 38.4 ms +- 0.7 ms ......................................... react_agent_10x_checkpoint_sync: Mean +- std dev: 36.9 ms +- 0.4 ms ......................................... react_agent_100x: Mean +- std dev: 343 ms +- 6 ms ......................................... react_agent_100x_sync: Mean +- std dev: 272 ms +- 3 ms ......................................... react_agent_100x_checkpoint: Mean +- std dev: 643 ms +- 9 ms ......................................... react_agent_100x_checkpoint_sync: Mean +- std dev: 623 ms +- 7 ms ......................................... wide_state_25x300: Mean +- std dev: 23.3 ms +- 0.5 ms ......................................... wide_state_25x300_sync: Mean +- std dev: 15.3 ms +- 0.1 ms ......................................... wide_state_25x300_checkpoint: Mean +- std dev: 249 ms +- 13 ms ......................................... wide_state_25x300_checkpoint_sync: Mean +- std dev: 246 ms +- 13 ms ......................................... wide_state_15x600: Mean +- std dev: 27.2 ms +- 0.5 ms ......................................... wide_state_15x600_sync: Mean +- std dev: 17.8 ms +- 0.1 ms ......................................... wide_state_15x600_checkpoint: Mean +- std dev: 429 ms +- 14 ms ......................................... wide_state_15x600_checkpoint_sync: Mean +- std dev: 426 ms +- 13 ms ......................................... wide_state_9x1200: Mean +- std dev: 27.3 ms +- 0.6 ms ......................................... wide_state_9x1200_sync: Mean +- std dev: 17.8 ms +- 0.4 ms ......................................... wide_state_9x1200_checkpoint: Mean +- std dev: 280 ms +- 13 ms ......................................... wide_state_9x1200_checkpoint_sync: Mean +- std dev: 276 ms +- 12 ms
Comparison against main: libs/langgraph/langgraph/graph/state.py#L1
+-----------------------------------------+---------+-----------------------+ | Benchmark | main | changes | +=========================================+=========+=======================+ | fanout_to_subgraph_100x_checkpoint | 764 ms | 751 ms: 1.02x faster | +-----------------------------------------+---------+-----------------------+ | fanout_to_subgraph_100x | 612 ms | 604 ms: 1.01x faster | +-----------------------------------------+---------+-----------------------+ | react_agent_100x_checkpoint | 649 ms | 643 ms: 1.01x faster | +-----------------------------------------+---------+-----------------------+ | react_agent_100x | 346 ms | 343 ms: 1.01x faster | +-----------------------------------------+---------+-----------------------+ | react_agent_100x_sync | 274 ms | 272 ms: 1.01x faster | +-----------------------------------------+---------+-----------------------+ | fanout_to_subgraph_100x_checkpoint_sync | 967 ms | 962 ms: 1.01x faster | +-----------------------------------------+---------+-----------------------+ | fanout_to_subgraph_10x_sync | 53.3 ms | 53.1 ms: 1.00x faster | +-----------------------------------------+---------+-----------------------+ | wide_state_25x300_sync | 15.3 ms | 15.3 ms: 1.00x slower | +-----------------------------------------+---------+-----------------------+ | wide_state_9x1200_sync | 17.7 ms | 17.8 ms: 1.00x slower | +-----------------------------------------+---------+-----------------------+ | wide_state_15x600_sync | 17.7 ms | 17.8 ms: 1.01x slower | +-----------------------------------------+---------+-----------------------+ | react_agent_10x_checkpoint | 38.2 ms | 38.4 ms: 1.01x slower | +-----------------------------------------+---------+-----------------------+ | Geometric mean | (ref) | 1.00x faster | +-----------------------------------------+---------+-----------------------+ Benchmark hidden because not significant (17): fanout_to_subgraph_10x_checkpoint_sync, fanout_to_subgraph_10x_checkpoint, wide_state_25x300_checkpoint_sync, wide_state_9x1200_checkpoint_sync, wide_state_9x1200_checkpoint, react_agent_10x_checkpoint_sync, react_agent_10x_sync, react_agent_100x_checkpoint_sync, wide_state_15x600, fanout_to_subgraph_10x, wide_state_15x600_checkpoint, wide_state_25x300_checkpoint, react_agent_10x, fanout_to_subgraph_100x_sync, wide_state_25x300, wide_state_9x1200, wide_state_15x600_checkpoint_sync