Enable raising Interrupt from inside a node, add list of current interrupts to get_state #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
reviewed
Aug 15, 2024
nfcampos
force-pushed
the
nc/14aug/dynamic-interrupt
branch
2 times, most recently
from
fa6f27f to
c8461f0
Compare
…rrupts to get_state
nfcampos
force-pushed
the
nc/14aug/dynamic-interrupt
branch
from
b3b71b5 to
ed192ad
Compare
nfcampos
commented
Aug 21, 2024
| @@ -550,7 +553,7 @@ def update_state( | |||
| saved = self.checkpointer.get_tuple(config) | |||
| checkpoint = copy_checkpoint(saved.checkpoint) if saved else empty_checkpoint() | |||
| checkpoint_previous_versions = ( | |||
| saved.checkpoint["channel_versions"] if saved else {} | |||
| saved.checkpoint["channel_versions"].copy() if saved else {} | |||
nfcampos
commented
Aug 21, 2024
| @@ -576,7 +579,7 @@ def update_state( | |||
| create_checkpoint(checkpoint, None, step), | |||
| { | |||
| "source": "update", | |||
| "step": step, | |||
| "step": step + 1, | |||
There was a problem hiding this comment.
also bug fix, less important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.