Implement serialization with msgpack library #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfcampos
commented
Sep 13, 2024
nfcampos
commented
- encode custom python objects with a msgpack extension type, with constructor path string, and args encoded as nested msgpack doc
- encode custom python objects with a msgpack extension type, with constructor path string, and args encoded as nested msgpack doc
- should use our serializer to load, as inputs to subgraphs are serialized using it
nfcampos
force-pushed
the
nc/13sep/msgpack
branch
from
c27e7d1 to
eacaa9b
Compare
|
Hey @nfcampos, it seems this change breaks redis checkpointer #1123 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.