Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs on disabling streaming #1775

Merged
merged 5 commits into from
Sep 23, 2024
Merged

docs: add docs on disabling streaming #1775

merged 5 commits into from
Sep 23, 2024

Conversation

isahers1
Copy link
Contributor

No description provided.

Copy link
Contributor

@nfcampos nfcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## With disabling sounds pretty strange

@isahers1
Copy link
Contributor Author

## With disabling sounds pretty strange

renamed to "Disabling streaming" - lmk if that sounds better

@vbarda vbarda merged commit d2d5e9f into main Sep 23, 2024
45 checks passed
@vbarda vbarda deleted the isaac/disablestreaming branch September 23, 2024 22:01
@VKudlay
Copy link

VKudlay commented Sep 24, 2024

Hey @isahers1. Just stumbled upon this and tried it out (didn't quite work ootb for my case, but no matter). Are there any more weedy details about how stream gets enforced in the nodes, and maybe a more general (maybe scope-based?) disabling technique? Asking since this is just relying on a very specific client supporting a very specific argument, which might take a while to bleed into other clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants