lib: Add support for multiple interrupts per node #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfcampos
commented
Dec 4, 2024
nfcampos
commented
- Includes support for interrupt loops
- Includes support for interrupt loops
hinthornw
reviewed
Dec 4, 2024
| @@ -37,13 +37,13 @@ | |||
| CONFIG_KEY_CHECKPOINT_NS, | |||
| CONFIG_KEY_CHECKPOINTER, | |||
| CONFIG_KEY_READ, | |||
| CONFIG_KEY_RESUME_VALUE, | |||
There was a problem hiding this comment.
Is CONFIG_KEY_RESUME_VALUE used anymore?
| @@ -263,8 +264,28 @@ def put_writes(self, task_id: str, writes: Sequence[tuple[str, Any]]) -> None: | |||
| """Put writes for a task, to be read by the next tick.""" | |||
| if not writes: | |||
| return | |||
| # deduplicate writes to special channels, last write wins | |||
There was a problem hiding this comment.
ooc: why do we know we don't have to deduplicate if one of the writes is to a regular channel?
There was a problem hiding this comment.
Regular channels can't be written to more than once (writes after the first are ignored)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.