Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorg multi-agent howtos #2784

Merged
merged 16 commits into from
Dec 18, 2024
Merged

docs: reorg multi-agent howtos #2784

merged 16 commits into from
Dec 18, 2024

Conversation

vbarda
Copy link
Collaborator

@vbarda vbarda commented Dec 16, 2024

No description provided.

@eyurtsev
Copy link
Contributor

MAJOR:

  1. Consider improving the header titles. For a how-to guide, we're not trying to find a specific example, we're trying to find a specific implementation (e.g., I want to use tools with react). Travel Recommendations Example (ReAct) -> Most users will not know what react is. They're looking for something that shows how tools can be used / added to agents.

We can create examples section at the very bottom if we want to add various examples.

  1. What should users with custom agents do? How do custom agent implementations typically look?

  2. Anyway to cut on complexity using 2 agents and still keep it meaningful?

MINOR:

  1. Should we include a TOC at the top of the how-to guide? (maybe not necessary since it'll be included automatically)
  2. Is there a way to have the agents use tools without the handoff having to be a tool? (I think not)
  3. Some details seem like they belong in the conceptual guide? (Ok here fro now, but this is good material for the conceptual guide)

image

  1. Could you document the function with google style doc-strings:

This is what people will use to understand what the function does.

def make_handoff_tool(*, agent_name: str):
    tool_name = f"transfer_to_{agent_name}"
  1. missing transition between the two code cells:

image

@vbarda vbarda changed the title docs: add tool-calling agent example to multi-agent howto docs: reorg multi-agent howtos Dec 17, 2024
@eyurtsev
Copy link
Contributor

Some paraphrasing if you like?

  1. Implementing a handoff tool -> implementing a handoff using a tool

  2. The output from for chunk in graph.stream( { "messages": [ ( "user", "what's (3 + 5) * 12" ) ] }, subgraphs=True ): print(chunk) print("\n")

    is not readable I think

  3. parallel_tool_calls=False -- does this work with all model providers? Can we add this to create react agent?

  4. Using with a prebuilt ReAct agent. Do we need to note somewhere that the scratch pad is shared? -- that's an important thing about this implementation

@vbarda vbarda marked this pull request as ready for review December 17, 2024 23:42
@vbarda vbarda enabled auto-merge (squash) December 17, 2024 23:53
@vbarda vbarda disabled auto-merge December 17, 2024 23:54
@vbarda vbarda enabled auto-merge (squash) December 17, 2024 23:56
@vbarda vbarda merged commit 532cb0a into main Dec 18, 2024
58 checks passed
@vbarda vbarda deleted the vb/react-multiagent-howto branch December 18, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants