Fix tracing hierarchy for imperative api #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty simple fix. Wish I could forget the |
hinthornw
approved these changes
Jan 15, 2025
eyurtsev
approved these changes
Jan 15, 2025
| @@ -148,9 +150,12 @@ def call( | |||
| input: Any, | |||
| *, | |||
| retry: Optional[RetryPolicy] = None, | |||
| callbacks: Optional[Callbacks] = None, | |||
There was a problem hiding this comment.
nit: Callbacks is already wrapped in an Optional in langchain_core
| task = self.executor.submit(next_tick, fn, *args, **kwargs) | ||
| task = cast( | ||
| concurrent.futures.Future[T], | ||
| self.executor.submit(next_tick, ctx.run, fn, *args, **kwargs), # type: ignore[arg-type] |
There was a problem hiding this comment.
nit: next_tick is a bit confusing on the sync side -- sleep(0) isn't guaranteed to context switch
There was a problem hiding this comment.
It is the closest equivalent. And yes it does context switch https://stackoverflow.com/a/7273727
There was a problem hiding this comment.
Also not something being changed in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.