Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Send order after interrupt/resume #3037

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

nfcampos
Copy link
Contributor

@nfcampos nfcampos commented Jan 15, 2025

  • order was incorrectly based on task id, instead of the correct task path
  • this requires storing task paths on checkpointers
  • addition of task_path to put_writes is made backwards compatible by checking signature on call, and treating it as an optional arg

Base automatically changed from nc/14jan/fix-tracing-hierarchy-imperative to main January 15, 2025 17:10
@nfcampos nfcampos force-pushed the nc/14jan/fix-send-order branch 3 times, most recently from bd61cc2 to efe347d Compare January 15, 2025 19:11
- order was incorrectly based on task id, instead of the correct task path
- this requires storing task paths on checkpointers
- addition of task_path to put_writes is made backwards compatible by checking signature on call, and treating it as an optinal arg
@nfcampos nfcampos force-pushed the nc/14jan/fix-send-order branch from efe347d to 0adbd89 Compare January 15, 2025 19:31
@nfcampos nfcampos merged commit aab6fdf into main Jan 15, 2025
48 checks passed
@nfcampos nfcampos deleted the nc/14jan/fix-send-order branch January 15, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant