Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up versioning and new docs outline #186

Merged
merged 4 commits into from
Apr 23, 2024
Merged

set up versioning and new docs outline #186

merged 4 commits into from
Apr 23, 2024

Conversation

agola11
Copy link
Contributor

@agola11 agola11 commented Apr 23, 2024

No description provided.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langsmith-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 5:55pm

@@ -0,0 +1,3 @@
[
"2.0"
Copy link
Contributor

@jacoblee93 jacoblee93 Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to make this match the actual LangSmith semver to avoid confusion? Keep in mind that these pathed sidebar links could be used in the future.

If this won't accompany a new LangSmith major/minor version, we could call this canary or something similar instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, if we don't expect to share this version of the docs widely, fine to leave

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use semver for non self hosted langsmith right now so this version specifier is pretty meaningless atm

@jacoblee93
Copy link
Contributor

A few small comments - btw swizzling is pretty easy for the unreleased docs callout if you want custom copy!

@agola11 agola11 merged commit d39f149 into main Apr 23, 2024
4 checks passed
@agola11 agola11 deleted the ankush/versioning branch April 23, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants