Skip to content

[Python]: Fix concurrency issues in caching for urllib3<2.0 #248

[Python]: Fix concurrency issues in caching for urllib3<2.0

[Python]: Fix concurrency issues in caching for urllib3<2.0 #248

Triggered via pull request November 6, 2024 09:31
Status Success
Total duration 20m 2s
Artifacts

py-bench.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 2 notices
benchmark
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Benchmark results: .github/actions/python-integration-tests/action.yml#L1
......................................... create_5_000_run_trees: Mean +- std dev: 617 ms +- 46 ms ......................................... create_10_000_run_trees: Mean +- std dev: 1.20 sec +- 0.06 sec ......................................... create_20_000_run_trees: Mean +- std dev: 1.21 sec +- 0.05 sec ......................................... dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 708 us +- 12 us ......................................... dumps_class_nested_py_leaf_50x100: Mean +- std dev: 25.7 ms +- 0.6 ms ......................................... dumps_class_nested_py_leaf_100x200: Mean +- std dev: 104 ms +- 2 ms ......................................... dumps_dataclass_nested_50x100: Mean +- std dev: 25.9 ms +- 0.3 ms ......................................... WARNING: the benchmark result may be unstable * the standard deviation (18.3 ms) is 25% of the mean (72.8 ms) Try to rerun the benchmark with more runs, values and/or loops. Run 'python -m pyperf system tune' command to reduce the system jitter. Use pyperf stats, pyperf dump and pyperf hist to analyze results. Use --quiet option to hide these warnings. dumps_pydantic_nested_50x100: Mean +- std dev: 72.8 ms +- 18.3 ms ......................................... WARNING: the benchmark result may be unstable * the standard deviation (35.5 ms) is 15% of the mean (230 ms) Try to rerun the benchmark with more runs, values and/or loops. Run 'python -m pyperf system tune' command to reduce the system jitter. Use pyperf stats, pyperf dump and pyperf hist to analyze results. Use --quiet option to hide these warnings. dumps_pydanticv1_nested_50x100: Mean +- std dev: 230 ms +- 36 ms
Comparison against main: .github/actions/python-integration-tests/action.yml#L1
+------------------------------------+----------+------------------------+ | Benchmark | main | changes | +====================================+==========+========================+ | dumps_class_nested_py_leaf_100x200 | 105 ms | 104 ms: 1.01x faster | +------------------------------------+----------+------------------------+ | dumps_dataclass_nested_50x100 | 25.6 ms | 25.9 ms: 1.01x slower | +------------------------------------+----------+------------------------+ | create_20_000_run_trees | 1.19 sec | 1.21 sec: 1.01x slower | +------------------------------------+----------+------------------------+ | dumps_class_nested_py_leaf_50x100 | 25.2 ms | 25.7 ms: 1.02x slower | +------------------------------------+----------+------------------------+ | dumps_pydantic_nested_50x100 | 68.1 ms | 72.8 ms: 1.07x slower | +------------------------------------+----------+------------------------+ | Geometric mean | (ref) | 1.02x slower | +------------------------------------+----------+------------------------+ Benchmark hidden because not significant (4): create_5_000_run_trees, dumps_class_nested_py_branch_and_leaf_200x400, create_10_000_run_trees, dumps_pydanticv1_nested_50x100