Skip to content

add mime type to attachment info #823

add mime type to attachment info

add mime type to attachment info #823

Triggered via pull request January 10, 2025 18:23
Status Success
Total duration 4m 42s
Artifacts

py-bench.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 2 notices
benchmark
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Benchmark results: python/langsmith/client.py#L1
........... create_5_000_run_trees: Mean +- std dev: 642 ms +- 57 ms ........... create_10_000_run_trees: Mean +- std dev: 1.32 sec +- 0.11 sec ........... create_20_000_run_trees: Mean +- std dev: 1.34 sec +- 0.09 sec ........... dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 699 us +- 12 us ........... dumps_class_nested_py_leaf_50x100: Mean +- std dev: 24.9 ms +- 0.2 ms ........... dumps_class_nested_py_leaf_100x200: Mean +- std dev: 104 ms +- 3 ms ........... dumps_dataclass_nested_50x100: Mean +- std dev: 25.2 ms +- 0.2 ms ........... WARNING: the benchmark result may be unstable * the standard deviation (18.5 ms) is 25% of the mean (72.9 ms) Try to rerun the benchmark with more runs, values and/or loops. Run 'python -m pyperf system tune' command to reduce the system jitter. Use pyperf stats, pyperf dump and pyperf hist to analyze results. Use --quiet option to hide these warnings. dumps_pydantic_nested_50x100: Mean +- std dev: 72.9 ms +- 18.5 ms ........... dumps_pydanticv1_nested_50x100: Mean +- std dev: 198 ms +- 4 ms
Comparison against main: python/langsmith/client.py#L1
+-----------------------------------------------+----------+------------------------+ | Benchmark | main | changes | +===============================================+==========+========================+ | dumps_pydanticv1_nested_50x100 | 213 ms | 198 ms: 1.08x faster | +-----------------------------------------------+----------+------------------------+ | create_5_000_run_trees | 661 ms | 642 ms: 1.03x faster | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_branch_and_leaf_200x400 | 709 us | 699 us: 1.01x faster | +-----------------------------------------------+----------+------------------------+ | dumps_dataclass_nested_50x100 | 25.5 ms | 25.2 ms: 1.01x faster | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_leaf_50x100 | 24.9 ms | 24.9 ms: 1.00x faster | +-----------------------------------------------+----------+------------------------+ | create_10_000_run_trees | 1.32 sec | 1.32 sec: 1.00x faster | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_leaf_100x200 | 103 ms | 104 ms: 1.01x slower | +-----------------------------------------------+----------+------------------------+ | create_20_000_run_trees | 1.31 sec | 1.34 sec: 1.02x slower | +-----------------------------------------------+----------+------------------------+ | dumps_pydantic_nested_50x100 | 65.7 ms | 72.9 ms: 1.11x slower | +-----------------------------------------------+----------+------------------------+ | Geometric mean | (ref) | 1.00x slower | +-----------------------------------------------+----------+------------------------+