Skip to content

Commit

Permalink
rm execution_order
Browse files Browse the repository at this point in the history
  • Loading branch information
hinthornw committed Jan 31, 2024
1 parent 1382bda commit 11ab613
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 19 deletions.
1 change: 0 additions & 1 deletion js/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ interface CreateRunParams {
name: string;
inputs: KVMap;
run_type: string;
execution_order?: number;
id?: string;
start_time?: number;
end_time?: number;
Expand Down
16 changes: 0 additions & 16 deletions js/src/run_trees.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ export interface RunTreeConfig {
run_type: string;
id?: string;
project_name?: string;
execution_order?: number;
child_execution_order?: number;
parent_run?: RunTree;
child_runs?: RunTree[];
start_time?: number;
Expand All @@ -39,8 +37,6 @@ export class RunTree implements BaseRun {
project_name: string;
parent_run?: RunTree;
child_runs: RunTree[];
execution_order: number;
child_execution_order: number;
start_time: number;
end_time?: number;
extra: KVMap;
Expand Down Expand Up @@ -83,8 +79,6 @@ export class RunTree implements BaseRun {
getEnvironmentVariable("LANGCHAIN_SESSION") ?? // TODO: Deprecate
"default",
child_runs: [],
execution_order: 1,
child_execution_order: 1,
api_url:
getEnvironmentVariable("LANGCHAIN_ENDPOINT") ?? "http://localhost:1984",
api_key: getEnvironmentVariable("LANGCHAIN_API_KEY"),
Expand All @@ -103,8 +97,6 @@ export class RunTree implements BaseRun {
parent_run: this,
project_name: this.project_name,
client: this.client,
execution_order: this.child_execution_order + 1,
child_execution_order: this.child_execution_order + 1,
});

this.child_runs.push(child);
Expand All @@ -119,13 +111,6 @@ export class RunTree implements BaseRun {
this.outputs = outputs;
this.error = error;
this.end_time = endTime;

if (this.parent_run) {
this.parent_run.child_execution_order = Math.max(
this.parent_run.child_execution_order,
this.child_execution_order
);
}
}

private async _convertToCreate(
Expand Down Expand Up @@ -163,7 +148,6 @@ export class RunTree implements BaseRun {
run_type: run.run_type,
reference_example_id: run.reference_example_id,
extra: runExtra,
execution_order: run.execution_order,
serialized: run.serialized,
error: run.error,
inputs: run.inputs,
Expand Down
2 changes: 0 additions & 2 deletions js/src/tests/client.int.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,6 @@ test.concurrent("Test getRunUrl with run", async () => {
const client = new Client({});
const run: Run = {
id: uuidv4(),
execution_order: 1,
name: "foo",
run_type: "llm",
inputs: { input: "hello world" },
Expand All @@ -632,7 +631,6 @@ test.concurrent("Test getRunUrl with run", async () => {
const client = new Client({});
const run: Run = {
id: "123",
execution_order: 1,
name: "foo",
run_type: "llm",
inputs: { input: "hello world" },
Expand Down

0 comments on commit 11ab613

Please sign in to comment.