Skip to content

Commit

Permalink
mom I did it!
Browse files Browse the repository at this point in the history
  • Loading branch information
bracesproul committed Apr 13, 2024
1 parent 0081216 commit ed3dc5b
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 22 deletions.
6 changes: 3 additions & 3 deletions .github/actions/js-integration-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ runs:
uses: actions/setup-node@v3
with:
node-version: ${{ inputs.node-version }}
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"

- name: Install Yarn dependencies
run: yarn install
run: yarn install --immutable --mode=skip-build --ignore-scripts
shell: bash
working-directory: js

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: 20.x
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: yarn install --immutable
run: yarn install --immutable --mode=skip-build --ignore-scripts
- name: Run JS integration tests
uses: ./.github/actions/js-integration-tests
with:
Expand Down
25 changes: 13 additions & 12 deletions .github/workflows/js_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,30 +31,31 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: 18.x
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: yarn install --immutable --mode=skip-build
run: yarn install --immutable --mode=skip-build --ignore-scripts
- name: Check formatting
run: yarn run format:check

lint:
name: Check linting
runs-on: ubuntu-latest
defaults:
run:
working-directory: "js"
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: "yarn"
cache-dependency-path: ./js/yarn.lock
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: yarn install --immutable --mode=skip-build --ignore-scripts
working-directory: "js"
- name: Check linting
run: yarn run lint
working-directory: "js"

build:
name: Build and check types
Expand All @@ -68,10 +69,10 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: 18.x
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: yarn install --immutable
run: yarn install --immutable --mode=skip-build --ignore-scripts
- name: Build and check types
run: yarn run build

Expand All @@ -97,10 +98,10 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: yarn install --immutable
run: yarn install --immutable --mode=skip-build --ignore-scripts
- name: Build
run: yarn run build
- name: Check version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
# cache: "yarn"
# cache-dependency-path: "js/yarn.lock"
cache: "yarn"
cache-dependency-path: "js/yarn.lock"
- name: Install dependencies
run: cd js && yarn install --immutable
- name: Build
Expand Down
2 changes: 1 addition & 1 deletion js/tsconfig.cjs.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "NodeNext",
"module": "commonjs",
"declaration": false
},
"exclude": [
Expand Down
2 changes: 1 addition & 1 deletion js/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"ES2022.Object",
"DOM"
],
"module": "NodeNext",
"module": "ES2020",
"moduleResolution": "nodenext",
"esModuleInterop": true,
"declaration": true,
Expand Down

0 comments on commit ed3dc5b

Please sign in to comment.