feat(js): upload and update examples multipart in JS #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isahers1
changed the title
agola11
approved these changes
Nov 17, 2024
isahers1
changed the title
isahers1
changed the title
agola11
reviewed
Dec 10, 2024
js/src/client.ts
Outdated
| example.attachments = attachmentsArray.reduce( | ||
| (acc, { key, value }) => { | ||
| if (value.reader != null) { | ||
| acc[key.startsWith("attachment.") ? key.slice(11) : key] = { |
There was a problem hiding this comment.
don't use 11 here. Use len("attachment.") or remove the prefix
jacoblee93
reviewed
Dec 11, 2024
| * @param updates List of ExampleUpdateWithAttachments objects to upsert | ||
| * @returns Promise with the update response | ||
| */ | ||
| public async updateExamplesMultipart( |
There was a problem hiding this comment.
Are we really naming a public API this?
Why not just updateExamples?
| * @param uploads List of ExampleUploadWithAttachments objects to upload | ||
| * @returns Promise with the upload response | ||
| */ | ||
| public async uploadExamplesMultipart( |
agola11
approved these changes
Dec 11, 2024
agola11
reviewed
Dec 11, 2024
jacoblee93
changed the title
jacoblee93
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.