-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate langsmith-pyo3
Python package
#1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to reduce the Python lower bound of the PyO3 bindings to 3.8 since Poetry refused to create a lockfile otherwise -- the langsmith project's own lower bound is 3.8.
This lets us defer string formatting until later, and aids batch-collection by tools such as Sentry. Otherwise we'll get a separate entry for each possible stack trace value here, which is not what we want.
Accept both strings and datetimes for `start_time` and `end_time` values.
hinthornw
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate of a
langsmith-pyo3
Python package aimed to speed up trace processing and submissions. Currently about 50% faster than the pure Python implementation, and likely that's just a starting point for further performance tuning.Includes wheels for all operating systems and major platforms, and trusted publishing to PyPI with attestations.