Remove links in vendored code that point outside the sdist source code. #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We vendor
pyo3and its related libraries, but we depend on users' build tools to build wheels when a suitable wheel is not found on PyPI. The source distribution only includes the actual source code ofpyo3et al, but their source code indirectly depends on non-source artifacts, such as files in theirguide/orexamples/directories. Those directories are not part of the source distribution, so locally building the wheel fails.This PR removes those links, since they are only used for doc comments and aren't relevant to the actual operation of our library.