Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only pop graph if 'serialized' is not none #1336

Merged
merged 4 commits into from
Dec 17, 2024
Merged

only pop graph if 'serialized' is not none #1336

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0782185
fix
isahers1 Dec 13, 2024
7e633b0
change
isahers1 Dec 13, 2024
1079b3e
will comment
isahers1 Dec 13, 2024
259fc88
fix
isahers1 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/langsmith/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Client for interacting with the LangSmith API.

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

...........
WARNING: the benchmark result may be unstable
* the standard deviation (98.6 ms) is 14% of the mean (713 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_5_000_run_trees: Mean +- std dev: 713 ms +- 99 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (196 ms) is 13% of the mean (1.46 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_10_000_run_trees: Mean +- std dev: 1.46 sec +- 0.20 sec
...........
WARNING: the benchmark result may be unstable
* the standard deviation (144 ms) is 10% of the mean (1.41 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_20_000_run_trees: Mean +- std dev: 1.41 sec +- 0.14 sec
...........
dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 685 us +- 14 us
...........
dumps_class_nested_py_leaf_50x100: Mean +- std dev: 24.8 ms +- 0.2 ms
...........
dumps_class_nested_py_leaf_100x200: Mean +- std dev: 104 ms +- 2 ms
...........
dumps_dataclass_nested_50x100: Mean +- std dev: 25.3 ms +- 0.4 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (17.3 ms) is 24% of the mean (71.8 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

dumps_pydantic_nested_50x100: Mean +- std dev: 71.8 ms +- 17.3 ms
...........
dumps_pydanticv1_nested_50x100: Mean +- std dev: 201 ms +- 5 ms

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------------+----------+------------------------+
| Benchmark                                     | main     | changes                |
+===============================================+==========+========================+
| dumps_pydanticv1_nested_50x100                | 217 ms   | 201 ms: 1.08x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_branch_and_leaf_200x400 | 695 us   | 685 us: 1.01x faster   |
+-----------------------------------------------+----------+------------------------+
| create_5_000_run_trees                        | 721 ms   | 713 ms: 1.01x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_50x100             | 24.8 ms  | 24.8 ms: 1.00x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_dataclass_nested_50x100                 | 25.2 ms  | 25.3 ms: 1.01x slower  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_100x200            | 103 ms   | 104 ms: 1.01x slower   |
+-----------------------------------------------+----------+------------------------+
| create_20_000_run_trees                       | 1.36 sec | 1.41 sec: 1.04x slower |
+-----------------------------------------------+----------+------------------------+
| create_10_000_run_trees                       | 1.37 sec | 1.46 sec: 1.07x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_pydantic_nested_50x100                  | 64.9 ms  | 71.8 ms: 1.11x slower  |
+-----------------------------------------------+----------+------------------------+
| Geometric mean                                | (ref)    | 1.01x slower           |
+-----------------------------------------------+----------+------------------------+

Use the client to customize API keys / workspace ocnnections, SSl certs,
etc. for tracing.
Expand Down Expand Up @@ -1179,7 +1179,7 @@
):
# Drop completely
run_create.pop("serialized", None)
else:
elif run_create["serialized"] is not None:
isahers1 marked this conversation as resolved.
Show resolved Hide resolved
# Drop graph
run_create["serialized"].pop("graph", None)

Expand Down
Loading