Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flush zstd and correctly get buffer size #1353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Flush zstd and correctly get buffer size #1353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a55526
fix: Flush zstd and correctly get buffer size
angus-langchain Dec 25, 2024
fbd8c7c
chore: use tell() instead of getbuffer()
angus-langchain Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/langsmith/_internal/_background_thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from __future__ import annotations

Check notice on line 1 in python/langsmith/_internal/_background_thread.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

...........
WARNING: the benchmark result may be unstable
* the standard deviation (83.4 ms) is 12% of the mean (691 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_5_000_run_trees: Mean +- std dev: 691 ms +- 83 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (174 ms) is 12% of the mean (1.39 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_10_000_run_trees: Mean +- std dev: 1.39 sec +- 0.17 sec
...........
WARNING: the benchmark result may be unstable
* the standard deviation (193 ms) is 14% of the mean (1.42 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_20_000_run_trees: Mean +- std dev: 1.42 sec +- 0.19 sec
...........
dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 690 us +- 11 us
...........
dumps_class_nested_py_leaf_50x100: Mean +- std dev: 25.0 ms +- 0.2 ms
...........
dumps_class_nested_py_leaf_100x200: Mean +- std dev: 103 ms +- 2 ms
...........
dumps_dataclass_nested_50x100: Mean +- std dev: 25.4 ms +- 0.2 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (15.7 ms) is 22% of the mean (72.0 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

dumps_pydantic_nested_50x100: Mean +- std dev: 72.0 ms +- 15.7 ms
...........
dumps_pydanticv1_nested_50x100: Mean +- std dev: 197 ms +- 2 ms

Check notice on line 1 in python/langsmith/_internal/_background_thread.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------------+----------+------------------------+
| Benchmark                                     | main     | changes                |
+===============================================+==========+========================+
| dumps_pydanticv1_nested_50x100                | 217 ms   | 197 ms: 1.10x faster   |
+-----------------------------------------------+----------+------------------------+
| create_5_000_run_trees                        | 717 ms   | 691 ms: 1.04x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_50x100             | 25.2 ms  | 25.0 ms: 1.01x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_100x200            | 104 ms   | 103 ms: 1.01x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_dataclass_nested_50x100                 | 25.5 ms  | 25.4 ms: 1.01x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_branch_and_leaf_200x400 | 691 us   | 690 us: 1.00x faster   |
+-----------------------------------------------+----------+------------------------+
| create_10_000_run_trees                       | 1.38 sec | 1.39 sec: 1.01x slower |
+-----------------------------------------------+----------+------------------------+
| create_20_000_run_trees                       | 1.40 sec | 1.42 sec: 1.01x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_pydantic_nested_50x100                  | 66.1 ms  | 72.0 ms: 1.09x slower  |
+-----------------------------------------------+----------+------------------------+
| Geometric mean                                | (ref)    | 1.01x faster           |
+-----------------------------------------------+----------+------------------------+

import concurrent.futures as cf
import functools
Expand Down Expand Up @@ -100,6 +100,7 @@
) -> Optional[io.BytesIO]:
assert client.compressed_runs is not None
with client.compressed_runs.lock:
client.compressed_runs.compressor_writer.flush()
current_size = client.compressed_runs.buffer.tell()

if size_limit is not None and size_limit <= 0:
Expand Down
Loading