Change LANGCHAIN_REVISION_ID to revision_id; use git describe as backup; don't overwrite metadata from env variables
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckup; don't overwrite metadata from env variables
hinthornw
approved these changes
Jan 18, 2024
python/langsmith/env/_runtime_env.py
Outdated
| .strip() | ||
| .decode() | ||
| ) | ||
| except Exception: |
There was a problem hiding this comment.
I think we should catch BaseException - include runtime errors and the like
python/langsmith/env/_runtime_env.py
Outdated
|
|
||
| try: | ||
| return ( | ||
| subprocess.check_output( |
There was a problem hiding this comment.
Any reason not to use _exec_git?
hinthornw
reviewed
Jan 18, 2024
python/langsmith/env/__init__.py
Outdated
| @@ -27,4 +27,5 @@ | |||
| "get_runtime_environment", | |||
| "get_system_metrics", | |||
| "get_git_info", | |||
| "exec_git", | |||
There was a problem hiding this comment.
Let's not export this on the env level (don't want to update our public API). We can still use with other internal files though
hinthornw
reviewed
Jan 18, 2024
python/langsmith/env/_git.py
Outdated
| return None | ||
| except subprocess.CalledProcessError as e: | ||
| logger.debug(f"Error running git command: {e}") | ||
| except (FileNotFoundError, subprocess.CalledProcessError, BaseException): |
There was a problem hiding this comment.
Could just do BaseException at this point! Captures all cases
hinthornw
reviewed
Jan 18, 2024
python/langsmith/env/_runtime_env.py
Outdated
| @functools.lru_cache(maxsize=1) | ||
| def _get_default_revision_id() -> Optional[str]: | ||
| """Get the default revision ID based on `git describe`.""" | ||
| import subprocess |
hinthornw
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.