Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Handoff #461

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Update Handoff #461

merged 8 commits into from
Feb 22, 2024

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Feb 21, 2024

Depends on langchain-ai/langchainjs#4477

Would update the tests to reflect this.

js/src/run_trees.ts Outdated Show resolved Hide resolved
js/src/run_trees.ts Outdated Show resolved Hide resolved
@jacoblee93
Copy link
Collaborator

I think seems reasonable but if you're using LangChain, couldn't you just wrap in a RunnableLambda?

Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love adding an implicit reverse dep like this but if it'll make people's lives easier I'm ok with it

js/src/tests/run_trees.int.test.ts Outdated Show resolved Hide resolved
js/src/run_trees.ts Outdated Show resolved Hide resolved
js/src/run_trees.ts Outdated Show resolved Hide resolved
js/src/run_trees.ts Outdated Show resolved Hide resolved
@hinthornw hinthornw merged commit 62c8932 into main Feb 22, 2024
10 of 11 checks passed
@hinthornw hinthornw deleted the wfh/update_handoff branch February 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants