Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic JS wrapClient method #485

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Add generic JS wrapClient method #485

merged 7 commits into from
Mar 6, 2024

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93 jacoblee93 commented Mar 3, 2024 •
edited
Loading

dqbd
dqbd reviewed Mar 3, 2024
View reviewed changes
js/src/client.ts Outdated Show resolved Hide resolved
@jacoblee93
Copy link
Collaborator Author

Example trace: https://smith.langchain.com/public/323d9897-2014-44eb-99d1-aa22691fa34a/r

@jacoblee93
Copy link
Collaborator Author

We might have to add an Anthropic key to CI if we want to do this @hinthornw

@jacoblee93 jacoblee93 marked this pull request as ready for review March 5, 2024 19:09
hinthornw
hinthornw approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@hinthornw hinthornw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need some custom handling to show how to handle streaming or other outputs (make them look like OAI format)?

@hinthornw hinthornw merged commit 5d93731 into main Mar 6, 2024
11 checks passed
@hinthornw hinthornw deleted the jacob/wrap_generic branch March 6, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinthornw hinthornw hinthornw approved these changes

@dqbd dqbd dqbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacoblee93 @dqbd @hinthornw