Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS[major]: Evaluate #621

Merged
merged 55 commits into from
Apr 30, 2024
Merged

JS[major]: Evaluate #621

merged 55 commits into from
Apr 30, 2024

Conversation

bracesproul
Copy link
Member

@bracesproul bracesproul commented Apr 23, 2024 •
edited
Loading

TODO:

  • figure out how to apply metadata at top level instead of with context like py does. inside _runEvaluators and _applySummaryEvaluators

@bracesproul bracesproul marked this pull request as draft April 23, 2024 00:37
@bracesproul bracesproul changed the title [WIP]JS[major]: Evaluate JS[major]: Evaluate Apr 26, 2024
@bracesproul bracesproul marked this pull request as ready for review April 26, 2024 01:01
@bracesproul bracesproul disabled auto-merge April 27, 2024 00:22
@bracesproul bracesproul requested a review from hinthornw April 27, 2024 00:22
@bracesproul bracesproul dismissed hinthornw’s stale review April 27, 2024 00:22

Implemented req changes

hinthornw
hinthornw reviewed Apr 29, 2024
View reviewed changes
js/src/traceable.ts Outdated Show resolved Hide resolved
@hinthornw
Copy link
Collaborator

hinthornw commented Apr 29, 2024 •
edited
Loading

Doesn't seem like we populate revision_id either in the experiment metadata by falling back to the git information, if that's rpovided - would like to do that

@hinthornw hinthornw enabled auto-merge (squash) April 30, 2024 18:31
@hinthornw hinthornw merged commit d9ef5db into main Apr 30, 2024
11 checks passed
@hinthornw hinthornw deleted the brace/js-evaluate branch April 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinthornw hinthornw hinthornw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bracesproul @hinthornw