Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional authentication #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

navalchand
Copy link

No description provided.

Copy link

vercel bot commented Oct 26, 2024

@navalchand is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up! I have a couple requests though:

  1. Instead of passing in just the anonymous user ID and none of the other User object fields, we should just have an AnonymousUser object which is exported & used in place of the one returned from supabase that has all the User fields populated (with dummy field ofc)
  2. This anonymous user object should be passed as props at the top level so that none of the sub components need to be updated
  3. The isAnonymousUser util should instead check for a new env var NEXT_PUBLIC_IS_AUTH_DISABLED, this way if someone wants to use auth but forgets to set the proper env vars they'll be alerted.

If you could make those changes that would be great. Just dismiss this review and re-request my review again once done! Thanks again.

@zhanghx0905
Copy link

This PR has diverged quite a bit from the main branch. 😔We do need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants