Javet: Integrate as code execution engine #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin7-1
added
the
theme: code execution engines
Martin7-1
reviewed
Dec 29, 2024
code-execution-engines/langchain4j-code-execution-engine-javet/pom.xml
Outdated
Show resolved
Hide resolved
code-execution-engines/langchain4j-code-execution-engine-javet/pom.xml
Outdated
Show resolved
Hide resolved
...-execution-engine-javet/src/main/java/dev/langchain4j/agent/V8JavaScriptExecutionEngine.java
Outdated
Show resolved
Hide resolved
...de-execution-engine-javet/src/main/java/dev/langchain4j/agent/V8JavaScriptExecutionTool.java
Outdated
Show resolved
Hide resolved
...cution-engine-javet/src/test/java/dev/langchain4j/agent/V8JavaScriptExecutionEngineTest.java
Outdated
Show resolved
Hide resolved
…/pom.xml Co-authored-by: Martin7-1 <[email protected]>
…/pom.xml Co-authored-by: Martin7-1 <[email protected]>
…/src/main/java/dev/langchain4j/agent/V8JavaScriptExecutionEngine.java Co-authored-by: Martin7-1 <[email protected]>
…/src/main/java/dev/langchain4j/agent/V8JavaScriptExecutionTool.java Co-authored-by: Martin7-1 <[email protected]>
…/src/test/java/dev/langchain4j/agent/V8JavaScriptExecutionEngineTest.java Co-authored-by: Martin7-1 <[email protected]>
|
Done. |
Martin7-1
reviewed
Dec 31, 2024
There was a problem hiding this comment.
@omarmahamid Thank you!
- Tool's IT is missing, could you please test tool if works correctly?
- Could you move the
ExecutionEnginetodev.langchain4j.community.code.javetpackage, and move theTooltodev.langchain4j.community.agent.tool.javetpackage?
| package dev.langchain4j.community.agent; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; |
There was a problem hiding this comment.
nit: Please always use the same assert framework (Prefer AssertJ).
| @@ -62,6 +62,7 @@ | |||
|
|
|||
| <!-- Integration of web search engine --> | |||
| <module>web-search-engines/langchain4j-community-web-search-engine-searxng</module> | |||
| <module>code-execution-engines/langchain4j-code-execution-engine-javet</module> | |||
There was a problem hiding this comment.
Looks like the directory name is not correctly. (Missing community)
|
|
||
| <dependency> | ||
| <groupId>dev.langchain4j</groupId> | ||
| <artifactId>langchain4j-code-execution-engine-graalvm-polyglot</artifactId> |
There was a problem hiding this comment.
nit: Looks like this dependency is not necessary
|
|
||
| <dependency> | ||
| <groupId>dev.langchain4j</groupId> | ||
| <artifactId>langchain4j</artifactId> |
There was a problem hiding this comment.
nit: Looks like this dependency is not necessary
|
|
||
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-junit-jupiter</artifactId> |
There was a problem hiding this comment.
nit: Looks like this dependency is not necessary
| } | ||
|
|
||
| @Override | ||
| public String execute(final String code) { |
There was a problem hiding this comment.
Suggested change
| public String execute(final String code) { | |
| public String execute(String code) { |
| import dev.langchain4j.agent.tool.Tool; | ||
| import dev.langchain4j.code.CodeExecutionEngine; | ||
|
|
||
| public class V8JavaScriptExecutionTool { |
There was a problem hiding this comment.
Suggested change
| public class V8JavaScriptExecutionTool { | |
| public class JavetJavaScriptExecutionTool { |
| @@ -0,0 +1,39 @@ | |||
| package dev.langchain4j.community.agent; | |||
There was a problem hiding this comment.
Could you please move it to dev.langchain4j.community.code.javet package?
| @@ -0,0 +1,24 @@ | |||
| package dev.langchain4j.community.agent; | |||
There was a problem hiding this comment.
Could you please move it to dev.langchain4j.community.agent.tool.javet package?
|
|
||
| public class V8JavaScriptExecutionEngine implements CodeExecutionEngine { | ||
|
|
||
| private final IJavetEnginePool<V8Runtime> javetEnginePool; |
There was a problem hiding this comment.
Looks like this pool does not close properly.
Martin7-1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #langchain4j/langchain4j#1984
#langchain4j/langchain4j#1983
we decide to add the v8 execution engine to lc4j community.
Change
General checklist
Checklist for adding new maven module
pom.xmlandlangchain4j-community-bom/pom.xmlChecklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringIT{NameOfIntegration}EmbeddingStoreRemovalITthat extends fromEmbeddingStoreWithRemovalITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j