Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckDB: Improve SQL management to avoid injection (#44) #45

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

fb64
Copy link
Contributor

@fb64 fb64 commented Jan 3, 2025

Issue

Fixes #44

Change

Use JDBC PreparedStatement instead of raw SQL to avoid injection in DuckDBEmbeddingStore

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit tests in all modules, and they are all green
  • I have manually run all integration tests in the module I have added/changed, and they are all green

@Martin7-1 Martin7-1 added bug Something isn't working P2 High priority theme: embedding store Issues/PRs related to embedding store labels Jan 3, 2025
@Martin7-1 Martin7-1 added this to the 1.0.0-alpha2 milestone Jan 3, 2025
Copy link
Collaborator

@Martin7-1 Martin7-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fb64 Thank you!

@Martin7-1 Martin7-1 merged commit 53d6056 into langchain4j:main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 High priority theme: embedding store Issues/PRs related to embedding store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuckDB Embeddings Store has SQL injection vulnerabilty
2 participants