Elasticsearch / Redis / Milvus: Remove lombok and small update for IT #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain4j
reviewed
Jan 2, 2025
| @@ -30,6 +30,7 @@ public RedisEmbeddingStore redisEmbeddingStore(RedisEmbeddingStoreProperties pro | |||
| @Nullable EmbeddingModel embeddingModel) { | |||
| String host = Optional.ofNullable(properties.getHost()).orElse(DEFAULT_HOST); | |||
| int port = Optional.ofNullable(properties.getPort()).orElse(DEFAULT_PORT); | |||
| String prefix = Optional.ofNullable(properties.getPrefix()).orElse(DEFAULT_INDEX_NAME + ":"); | |||
There was a problem hiding this comment.
Isn't default value for prefix embedding:? Using DEFAULT_INDEX_NAME (langchain4j-index) is a breaking change, no?
There was a problem hiding this comment.
Yeah...You are right. Maybe we should also remove the default value of indexName in spring boot starter, WDYT?
There was a problem hiding this comment.
Yes, I guess defaults should be specified in the "core" lc4j modules, not in the spring boot starter
There was a problem hiding this comment.
But if you are going to remove anything, please make sure those are not breaking changes
There was a problem hiding this comment.
Sure. I only remove prefix for now.
...ava/dev/langchain4j/store/embedding/redis/spring/RedisEmbeddingStoreAutoConfigurationIT.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes langchain4j#2336
Change
lombokin Elasticsearch / Redis / Milvusmaven-source-plugin:test-jar-no-forkforlangchain4j-spring-boot-tests, in order to see test source in community repo.prefixparameter introducing in this PRGeneral checklist