-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1827 ComponentScan with SPEL will not parse #48
Conversation
@qing-wq thanks a lot! Could you please add a test that tests the situation in langchain4j/langchain4j#1827 (comment)? 🙏 |
I added new test cases and removed the redundant tests about SpringBootApplication, which was not required |
@qing-wq thanks! Why removing existing tests though? |
I've learned that @AliasFor(annotation = ComponentScan.class, attribute = "basePackages")
String[] scanBasePackages() default {};
@AliasFor(annotation = ComponentScan.class, attribute = "basePackageClasses")
Class<?>[] scanBasePackageClasses() default {}; |
@qing-wq I would still keep it, assuming there is no harm and test is fast |
I understand, and I canceled my modification |
@qing-wq please check the tests, they all failed. |
sorry, there are some errors in my test code, but now I have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qing-wq thank you!
...n4j/service/spring/mode/automatic/differentPackage/package1/DifferentPackageAiServiceIT.java
Outdated
Show resolved
Hide resolved
…service/spring/mode/automatic/differentPackage/package1/DifferentPackageAiServiceIT.java
Fixes langchain4j/langchain4j#1827
fix ComponentScan basePackages with placeholders will not be parsed.
Changes Made: