Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show controls for gif in docs #1132

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: show controls for gif in docs #1132

merged 1 commit into from
Dec 20, 2024

Conversation

marcklingen
Copy link
Member

@marcklingen marcklingen commented Dec 20, 2024

Important

Fixes Video.tsx to show controls for GIFs by adjusting MediaPlayer controls condition.

  • Behavior:
    • In Video.tsx, change controls condition in MediaPlayer to gifStyle || panelDismissed to show controls for GIFs.
    • Remove unnecessary overlay div when gifStyle is true.

This description was created by Ellipsis for b3fc8af. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-docs ✅ Ready (Inspect) Visit Preview Dec 20, 2024 11:09pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Dec 20, 2024
@marcklingen marcklingen added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 0b55e2d Dec 20, 2024
7 checks passed
@marcklingen marcklingen deleted the marc/lfe-3051 branch December 20, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant