Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: embedding pipeline #589

Merged
merged 6 commits into from
May 3, 2024
Merged

fix: embedding pipeline #589

merged 6 commits into from
May 3, 2024

Conversation

marcklingen
Copy link
Member

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:09am

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

📦 Next.js Bundle Analysis for langfuse-docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

📦 Next.js Bundle Analysis for langfuse-docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

📦 Next.js Bundle Analysis for langfuse-docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@marliessophie marliessophie marked this pull request as ready for review May 3, 2024 07:39
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

📦 Next.js Bundle Analysis for langfuse-docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@marliessophie marliessophie enabled auto-merge (squash) May 3, 2024 08:07
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

📦 Next.js Bundle Analysis for langfuse-docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@marliessophie marliessophie merged commit 2c10df9 into main May 3, 2024
7 checks passed
@marliessophie marliessophie deleted the fix-embedding branch May 3, 2024 08:09
marcklingen
marcklingen commented May 3, 2024
View reviewed changes
cookbook/prompt_management_langchain.ipynb
@@ -161,28 +161,18 @@
]
Copy link
Member Author

@marcklingen marcklingen May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the notebook, the following needs to remain as a code block

# Get current production version of prompt 
langfuse_prompt = langfuse.get_prompt("event-planner")

Reply via ReviewNB

cookbook/prompt_management_openai_functions.ipynb
@@ -208,36 +208,23 @@
]
Copy link
Member Author

@marcklingen marcklingen May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to only move the output to a md block, we still need to call summarize story to produce an actual trace in this notebook

summary = summarize_story(STORY)

Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marliessophie marliessophie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcklingen @marliessophie