Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app token's last_used_at can't be updated when last_used_at is null #12770

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: app token's last_used_at can't be updated when last_used_at is null #12770

merged 2 commits into from
Jan 22, 2025

Conversation

Egfly
Copy link
Contributor

@Egfly Egfly commented Jan 15, 2025 •
edited by crazywoola
Loading

Summary

Close #12911

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 15, 2025
@Egfly Egfly closed this Jan 15, 2025
@Egfly Egfly deleted the fix/app-token-last-use-at-can-not-update branch January 15, 2025 10:22
@Egfly Egfly restored the fix/app-token-last-use-at-can-not-update branch January 15, 2025 10:26
@Egfly Egfly deleted the fix/app-token-last-use-at-can-not-update branch January 15, 2025 10:28
@Egfly Egfly restored the fix/app-token-last-use-at-can-not-update branch January 15, 2025 10:28
@Egfly Egfly reopened this Jan 15, 2025
@crazywoola
Copy link
Member

Please link an existing issue or creating one :) and the CI tests are failed.

@Egfly Egfly mentioned this pull request Jan 21, 2025
Closed
5 tasks
@Egfly
Copy link
Contributor Author

Egfly commented Jan 21, 2025

Please link an existing issue or creating one :) and the CI tests are failed.

thks, I have re-formatted the code using ruff and created the issue.

crazywoola
crazywoola approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @laipz8200 need to check the database usage.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
laipz8200
laipz8200 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 05a0faf into langgenius:main Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Secret key LAST USED can not be update
3 participants
@Egfly @crazywoola @laipz8200