Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support config chunk length by env #12925

Merged
merged 3 commits into from
Jan 22, 2025
Merged

feat: support config chunk length by env #12925

merged 3 commits into from
Jan 22, 2025

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Jan 22, 2025

Summary

Support config chunk length by env.

Fixes #12500

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 💪 enhancement New feature or request labels Jan 22, 2025
WTW0313
WTW0313 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@WTW0313 WTW0313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@iamjoel iamjoel merged commit e09f6e4 into main Jan 22, 2025
15 of 17 checks passed
@iamjoel iamjoel deleted the feat/chunk-length-support-env branch January 22, 2025 02:43
@laipz8200 laipz8200 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douxc douxc douxc approved these changes

@WTW0313 WTW0313 WTW0313 approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The chunk size of the knowledge base cannot be modified through environment variables.
3 participants
@iamjoel @douxc @WTW0313