Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cmakelists for release. #396

Merged
merged 3 commits into from
Jul 30, 2024
Merged

update cmakelists for release. #396

merged 3 commits into from
Jul 30, 2024

Conversation

dholladay00
Copy link
Collaborator

@dholladay00 dholladay00 commented Jul 24, 2024

PR Summary

Prepare for release!

@Yurlungur @jhp-lanl @rbberger @mauneyc-LANL

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@jhp-lanl
Copy link
Collaborator

Before the release, can we take a hard look at our package.py and make sure the dependencies make sense. Basically I want to make sure the correct things are pointing @1.9.0 rather than @main.

For example:

depends_on("[email protected]:", when="@main +tests")

should be

depends_on("[email protected]:", when="@1.9.0: +tests")

I think, right?

I also put in the ports-of-call 1.6.0 dependency, but I chose a non-existent version number:

depends_on("[email protected]:", when="@1.8.1:")

I think those are the only two things that might need looking at.

@jhp-lanl
Copy link
Collaborator

Before the release, can we take a hard look at our package.py and make sure the dependencies make sense. Basically I want to make sure the correct things are pointing @1.9.0 rather than @main.

I should add, this can be done separate from this MR if need be

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @jhp-lanl 's concerns LGTM

@jhp-lanl
Copy link
Collaborator

@rbberger can you take a look at the package.py and make sure my comments are correct and/or whether we need any other changes before release.

@jhp-lanl
Copy link
Collaborator

Other than updating the changelog, this looks good to me!

@dholladay00
Copy link
Collaborator Author

This is ready @Yurlungur @jhp-lanl

@Yurlungur Yurlungur merged commit cfb7d4b into main Jul 30, 2024
5 checks passed
@Yurlungur Yurlungur deleted the dholladay00/release_190 branch July 30, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants