Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spiner submodule, for new Databox::interpToReal overload. #462

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

RyanWollaeger
Copy link
Contributor

PR Summary

  • A dependent code consumes spiner through singularity-eos and singularity-opac.
  • The change in the spiner submodule should not currently affect anything singularity-eos, but is needed indirectly from the dependent code (it needs to be consistent with the submodule in singularity-opac).

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@RyanWollaeger
Copy link
Contributor Author

RyanWollaeger commented Feb 5, 2025

@Yurlungur - sorry for the cross-repo spiner submodule update - this should be the last one to get things working in a pending jaybenne change set.

@Yurlungur Yurlungur merged commit c6e7c43 into lanl:main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants